KAFKA-14744; NPE while converting OffsetFetch from version < 8 to version >= 8 #13295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
commented
Feb 23, 2023
| @@ -126,6 +126,56 @@ class OffsetFetchRequestTest extends BaseRequestTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| def testOffsetFetchRequestAllOffsetsSingleGroup(): Unit = { | |||
There was a problem hiding this comment.
This one is based on testOffsetFetchRequestSingleGroup. I kept the exact same assertions.
dajac
commented
Feb 23, 2023
| buildRequest(new OffsetFetchRequest.Builder( | ||
| "group-1", | ||
| false, | ||
| null, // all offsets. |
There was a problem hiding this comment.
This is the important bit. We need to test with null.
|
Could it produce NPE too? For example, server receives request from older client but the request fails due to authorization ( https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1362 ) |
|
Topics is only nullable since version 2: https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/OffsetFetchRequest.json#L41. So it should not happen there. |
jolshan
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring the OffsetFetch handling in KafkaApis, we introduced a NullPointerException (NPE). The NPE arises when the FetchOffset API is called with a client using a version older than version 8 and using null for the topics to signal that all topic-partition offsets must be returned. This means that this bug mainly impacts admin tools. The consumer does not use null.
This NPE is here: 24a8642#diff-0f2f19fd03e2fc5aa9618c607b432ea72e5aaa53866f07444269f38cb537f3feR237.
We missed this during the refactor because we had no tests in place to test this mode.
Committer Checklist (excluded from commit message)