KAFKA-3669: Add secondary constructor for KafkaConfig with a default … #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is for kafka's trunk branch. |
|
It was intentional not to add this constructor back in |
|
Yeah, Spark Streaming relies on this. I don't think it's a big change for Kafka to make, so I'd prefer if Kafka made this change. That way we don't have to do reflection in Spark to be able to build against Kafka 0.9 and 0.10, it save us a bunch of work:-) |
|
LGTM, will merge once the tests pass. |
|
LGTM. |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2016
…value for doLog …value for doLog Author: Mark Grover <mark@apache.org> Reviewers: Grant Henke <granthenke@gmail.com>, Ismael Juma <ismael@juma.me.uk> Closes #1334 from markgrover/kafka-3669-trunk (cherry picked from commit 58f9d7c) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
…value for doLog …value for doLog Author: Mark Grover <mark@apache.org> Reviewers: Grant Henke <granthenke@gmail.com>, Ismael Juma <ismael@juma.me.uk> Closes apache#1334 from markgrover/kafka-3669-trunk
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…value for doLog