-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-14491: [22/N] Add test for manual upgrade to versioned store #13449
Conversation
ef1888c
to
5c294f6
Compare
|
||
streamsBuilder | ||
.addStateStore( | ||
Stores.timestampedKeyValueStoreBuilder( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs (pre PR) might also be affected, but we do support upgrade even from plain KV-stores? If yes, we should test it, too, if no, we should be explicit in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, as long as the changelog topic format is the same it'll work, which means non-timestamped stores are eligible for upgrade too. Added an additional test.
The docs PR just says "non-versioned" right now (no mention of timestamped vs non-timestamped). I can add a line to make it clear that upgrading from both timestamped and non-timestamped stores are supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add a line to make it clear that upgrading from both timestamped and non-timestamped stores are supported.
Sounds like a good idea. Thx.
Not 100% sure what this means. Will retrigger Jenkins to see if it goes away. |
6be34ca
to
1e80dee
Compare
This PR adds an integration test for the manual upgrade scenario to upgrade a non-versioned store to a versioned store. The procedure is outlined in KIP-889 and also in the docs added in #13444:
Committer Checklist (excluded from commit message)