KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka cl… #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viktorsomogyi @C0urante @mimaison You had some changes/review in this part of the code lately, could you please review? |
|
Hey @urbandan, it's looking like this week is going to be pretty busy for me so I may not be able to take a look immediately. I can try to take a look next week if this still hasn't received a review by then. |
C0urante
reviewed
Mar 29, 2023
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
Outdated
Show resolved
Hide resolved
...ct/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
Outdated
Show resolved
Hide resolved
|
@C0urante Thank you for the review, addressed your comments |
C0urante
reviewed
Mar 31, 2023
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
Outdated
Show resolved
Hide resolved
...ct/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
Outdated
Show resolved
Hide resolved
urbandan
force-pushed
the
KAFKA-14838_mm2_client_ids
branch
from
4121411
to
d0e8960
Compare
|
@C0urante Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ient.id configs
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)