Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14906:Extract the coordinator service log from server log #13568

Closed
wants to merge 1 commit into from

Conversation

hudeqi
Copy link
Collaborator

@hudeqi hudeqi commented Apr 14, 2023

Currently, the coordinator service log and server log are mixed together. When troubleshooting the coordinator problem, it is necessary to filter from the server log, which is not very convenient. Therefore, the coordinator log is separated like the controller log.

@divijvaidya
Copy link
Contributor

This would be a breaking change since users will have to change their operational scripts & runbooks to look for coordinator logs in a different file. Perhaps we should target this for 4.x?

@hudeqi
Copy link
Collaborator Author

hudeqi commented Apr 14, 2023

This would be a breaking change since users will have to change their operational scripts & runbooks to look for coordinator logs in a different file. Perhaps we should target this for 4.x?

Do you mean that this change can be considered in the initial version of Kafka 4.x?
If so, is this PR always open or is it in a certain state?

@divijvaidya
Copy link
Contributor

I would suggest to mark the "fix version" of the JIRA as 4.0 and close this PR. It could be opened again when we start working on 4.0 as release target. There is currently no date decided in the community on when is that going to happen.

@hudeqi
Copy link
Collaborator Author

hudeqi commented Apr 14, 2023

I would suggest to mark the "fix version" of the JIRA as 4.0 and close this PR. It could be opened again when we start working on 4.0 as release target. There is currently no date decided in the community on when is that going to happen.

OK, thx!

@hudeqi hudeqi closed this Apr 14, 2023
@hudeqi hudeqi reopened this Apr 19, 2023
@hudeqi hudeqi marked this pull request as draft April 19, 2023 09:25
@kirktrue
Copy link
Contributor

Logging configuration is something the administrator can change as desired, right? Is there a clear benefit to the majority of users for this change? I can imagine it being a welcome change for some and an unexpected burden for others.

Note: since I am not a Kafka administrator, feel free to ignore my comment 😉

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jul 28, 2023
@hudeqi hudeqi closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs
Projects
None yet
3 participants