KAFKA-14950: implement assign() and assignment() #13605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnee
changed the title
kirktrue
reviewed
Apr 28, 2023
| updateMetadata(time.milliseconds()); | ||
| } | ||
|
|
||
| private void updateMetadata(long milliseconds) { |
There was a problem hiding this comment.
Nitpicky: can we fold updateMetadata into assign?
| @@ -537,7 +568,9 @@ public void subscribe(Pattern pattern) { | |||
|
|
|||
| @Override | |||
| public void unsubscribe() { | |||
| throw new KafkaException("method not implemented"); | |||
| // fetcher.clearBufferedDataForUnassignedPartitions(Collections.emptySet()); | |||
There was a problem hiding this comment.
I'm wondering if we want to push the clearing of buffered data and SubscriptionState mutation into the background thread so that it's executed together?
The coordinator's onLeavePrepare needs to know what partitions are being removed. As it's written, it's possible that the set of partitions could be removed before the background thread gets a chance to run the onLeavePrepare logic.
lianetm
reviewed
May 1, 2023
| consumer = spy(newConsumer(time, new StringDeserializer(), new StringDeserializer())); | ||
| consumer.assign(singleton(new TopicPartition("foo", 3))); | ||
| assertTrue(consumer.subscription().isEmpty()); | ||
| assertTrue(consumer.assignment().isEmpty()); |
There was a problem hiding this comment.
Shouldn't it be expected to have the foo-3 assignment here? (assigned from user in the subscriptionState as a result of the previous consumer.assign)
|
closingi this in light of #13797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: I implemented assign() and assignment(). Ported the original tests from the KafkaConsumerTest.java
Different to the original Implementation:
Missing: