KAFKA-14669: Use the generated docs for MirrorMaker configs in the doc #13658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0urante
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Thanks @tinaselenge, this will be a great enhancement for our docs! Left some thoughts; LMKWYT.
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConfig.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConfig.java
Outdated
Show resolved
Hide resolved
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConfig.java
Outdated
Show resolved
Hide resolved
|
@C0urante thank you so much for reviewing the PR, good suggestions! I made the changes as you suggested. |
C0urante
reviewed
Jul 17, 2023
C0urante
approved these changes
Jul 18, 2023
3 tasks
jolshan
added a commit
to confluentinc/kafka
that referenced
this pull request
Jul 18, 2023
* ak/trunk: (110 commits) MINOR: Update docs to include ZK deprecation notice and information (apache#14031) KAFKA-15091: Fix misleading Javadoc for SourceTask::commit (apache#13948) KAFKA-14669: Use the generated docs for MirrorMaker configs in the doc (apache#13658) KAFKA-14953: Add tiered storage related metrics (apache#13944) KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector (apache#13945) Revert "MINOR: Update .asf.yaml file with refreshed github_whitelist, and collaborators" (apache#14037) MINOR: Update .asf.yaml file with refreshed github_whitelist, and collaborators KAFKA-14737: Move kafka.utils.json to server-common (apache#13585) KAFKA-14647: Move TopicFilter to server-common/utils (apache#13158) MINOR: remove unused variable in examples (apache#14021) ...
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Jul 21, 2023
apache#13658) Reviewers: Chris Egerton <chrise@aiven.io>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
apache#13658) Reviewers: Chris Egerton <chrise@aiven.io>
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
apache#13658) Reviewers: Chris Egerton <chrise@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all three generated docs for MirrorMaker contain fields from BASE_CONNECTOR_CONFIG_DEF which results in duplicated fields when using them in the doc. This PR separates BASE_CONNECTOR_CONFIG_DEF from the config definitions for source, checkpoint and heartbeat so that the html docs are generated without duplicated fields.
Committer Checklist (excluded from commit message)