Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test #13664

Merged
merged 1 commit into from
May 26, 2023
Merged

KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test #13664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...rc/test/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThreadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.test.TestUtils;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
Expand All @@ -42,8 +43,8 @@
import static org.apache.kafka.clients.consumer.ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG;
import static org.apache.kafka.clients.consumer.ConsumerConfig.RETRY_BACKOFF_MS_CONFIG;
import static org.apache.kafka.clients.consumer.ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
Expand Down Expand Up @@ -89,11 +90,14 @@ public void setup() {
}

@Test
public void testStartupAndTearDown() {
public void testStartupAndTearDown() throws InterruptedException {
when(coordinatorManager.poll(anyLong())).thenReturn(mockPollCoordinatorResult());
when(commitManager.poll(anyLong())).thenReturn(mockPollCommitResult());
Comment on lines +94 to +95
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These stubs call where missing thus causing the NPE as indicated in the JIRA

DefaultBackgroundThread backgroundThread = mockBackgroundThread();
backgroundThread.start();
assertTrue(backgroundThread.isRunning());
TestUtils.waitForCondition(backgroundThread::isRunning, "Failed awaiting for the background thread to be running");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will wait up to 15s, the default timeout. It should be good enough!

backgroundThread.close();
assertFalse(backgroundThread.isRunning());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that isRunning() could take some time to return false or is it guaranteed to be set by the time close() is finished?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @kirktrue

It is guaranteed that is running will be false when close() is called:

kafka/clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java

Line 230 in 6c3e82f

this.running = false;

}

@Test
Expand Down