KAFKA-14462; [13/N] CoordinatorEvent and CoordinatorEventProcessor #13666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirktrue
reviewed
May 3, 2023
...p-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java
Show resolved
Hide resolved
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Show resolved
Hide resolved
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Outdated
Show resolved
Hide resolved
|
@kirktrue Thanks for your comments. I have addressed them. |
jolshan
reviewed
May 30, 2023
...ator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Outdated
Show resolved
Hide resolved
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java
Show resolved
Hide resolved
...rc/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java
Show resolved
Hide resolved
...rc/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java
Outdated
Show resolved
Hide resolved
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Show resolved
Hide resolved
jeffkbkim
reviewed
May 30, 2023
...or/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java
Show resolved
Hide resolved
...rc/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java
Show resolved
Hide resolved
jolshan
reviewed
May 31, 2023
| /** | ||
| * A {{@link CoordinatorEvent}} processor. | ||
| */ | ||
| public interface CoordinatorEventProcessor extends AutoCloseable { |
There was a problem hiding this comment.
Do we have any plans to make other coordinator event processors besides the multi-threaded one?
There was a problem hiding this comment.
Yep. I use a different implementation in unit tests (without threads) and I plan to use another one for simulation tests at some point.
3 tasks
jeffkbkim
reviewed
Jun 1, 2023
...p-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java
Show resolved
Hide resolved
...ator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEventProcessor.java
Show resolved
Hide resolved
...rc/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java
Show resolved
Hide resolved
jolshan
reviewed
Jun 1, 2023
| */ | ||
| public synchronized void beginShutdown() { | ||
| if (shuttingDown) { | ||
| log.debug("Event processor is already shutting down."); |
There was a problem hiding this comment.
extremely minor nit that we may not even want to change -- but in theory, we could already be done "shutting down" right? Maybe not a huge complaint, but the log could be confusing if close() has already completed.
There was a problem hiding this comment.
That's right. I think that the aim of this log is to catch cases where this class would be shutdown more than once by mistake so it does not have to 100% correct.
jolshan
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CoordinatorEvent, CoordinatorEventProcessor, and MultiThreadedEventProcessor.
Committer Checklist (excluded from commit message)