Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14462; [14/N] Add PartitionWriter #13675

Merged
merged 11 commits into from Jun 6, 2023
Merged

Conversation

dajac
Copy link
Contributor

@dajac dajac commented May 4, 2023

This patch introduces the PartitionWriter interface in the group-coordinator module. The ReplicaManager resides in the core module and it is thus not accessible from the group-coordinator one. The PartitionWriterImpl is basically an implementation of the interface residing in core which interfaces with the ReplicaManager.

One notable difference from the usual produce path is that the PartitionWriter returns the offset following the written records. This is then used by the coordinator runtime (coming later) to track when the request associated with the write can be completed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 label May 4, 2023
@dajac dajac changed the title KAFKA-14462; [14/N]; Add PartitionWriter KAFKA-14462; [14/N] Add PartitionWriter May 4, 2023
@dajac dajac requested a review from jolshan June 2, 2023 09:32
@jolshan
Copy link
Contributor

jolshan commented Jun 2, 2023

Hey David -- whenever we update appendRecords we have to modify a ton of tests that mock the method. (Basically add a ton of any(), since the mocker doesn't get default args). There are 283 failing now 😅

See here for an example of a PR that updates them: https://github.com/apache/kafka/pull/13391/files

@dajac
Copy link
Contributor Author

dajac commented Jun 2, 2023

Yeah, I have noticed all the failed tests. I will fix them.

@jolshan
Copy link
Contributor

jolshan commented Jun 5, 2023

These connect and kraft tests are a little concerning. They seem unrelated but maybe we should file a jira.

Copy link
Contributor

@jeffkbkim jeffkbkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dajac dajac merged commit 7d147cf into apache:trunk Jun 6, 2023
1 check failed
@dajac dajac deleted the KAFKA-14462-14 branch June 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants