Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-10337: await async commits in commitSync even if no offsets given #13678

Merged
merged 1 commit into from Jun 7, 2023
Merged

KAFKA-10337: await async commits in commitSync even if no offsets given #13678

merged 1 commit into from Jun 7, 2023

Commits on Jun 7, 2023

  1. KAFKA-10337: await async commits in commitSync even if no offsets given 

    The contract for commitSync() guarantees that the callbacks for all prior async commits will be invoked before it (successfully?) returns.
Prior to this change the contract could be violated if an empty offsets map were passed in to commitSync().

Co-authored-by: Erik van Oosten <e.vanoosten@grons.nl>
Co-authored-by: Philip Nee <philipnee@gmail.com>
    @thomaslee @erikvanoosten @philipnee
    3 people committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e4ba315 View commit details
    Browse the repository at this point in the history