KAFKA-15007: Always update the MetadataPropagator with correct MV. #13732
Conversation
Even if the MigrationDriver is not in DUAL_WRITE mode, it should pass the MV changes to the MetadataPropagator. If not, the propagator might not have the right version to send UMR, LISR and StopReplica requests when the migration is in DUAL_WRITE mode.
|
@akhileshchg what do you think about passing a supplier down to MetadataPropagator rather than the MV value? This way, we'll always be guaranteed to be using the MV in the MetadataImage known to KRaftMigrationDriver. |
…he metadataVersion. test
There was a problem hiding this comment.
Thanks for the patch, @akhileshchg. Just one question inline
| @@ -70,7 +68,7 @@ class MigrationPropagator( | |||
| val requestBatch = new MigrationPropagatorBatch( | |||
| config, | |||
| metadataProvider, | |||
| () => metadataVersion, | |||
| () => _image.features().metadataVersion(), | |||
There was a problem hiding this comment.
One subtle difference in behavior here is that the MV of the empty image is IBP_3_0_IV1, so the default we previously had of IBP_3_4_IV0 is no longer seen.
However.. I don't think we actually hit these defaults in practice since we won't call the metadata propagator until we've seen at least one metadata publish. @akhileshchg can you confirm if my assumption is correct?
There was a problem hiding this comment.
Yes. That's correct. For MigrationPropagator to first publish something, it should be called with an associated image. We use this image to setup the correct metadata version required to send the requests to ZkBrokers.
…13732) Use the MetadataVersion from the MetadataImage passed to MetadataPropagator. The ensures the propagator sends the right versions of UMR, LISR and StopReplica requests when the migration is in DUAL_WRITE mode. Reviewers: David Arthur <mumrah@gmail.com>
Even if the MigrationDriver is not in DUAL_WRITE mode, it should pass the MV changes to the MetadataPropagator. If not, the propagator might not have the right version to send UMR, LISR and StopReplica requests when the migration is in DUAL_WRITE mode.