KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode. #13741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Zk during DUAL_WRITE mode. We're missing updating new resourcePatterns while migrating ACL metadata from snapshot to Zk. Fixed and added a test to verify the correct behavior.
mumrah
approved these changes
May 22, 2023
mumrah
reviewed
May 22, 2023
There was a problem hiding this comment.
The jira talks about ACLs and ClientQuotas.
Were you planning on fixing ClientQuotas in this PR as well? If not, we can go ahead and merge the ACLs fix and work on ClientQuotas separately (maybe @pprovenzano could incorporate that into his test PR?)
I'm not planning to work on the ClientQuotas due to lack of time. |
|
Ok, I split out the client quotas work into KAFKA-15017 |
cmccabe
pushed a commit
that referenced
this pull request
May 26, 2023
When loading a snapshot during dual-write mode, we were missing the logic to detect new ACLs that had been added on the KRaft side. This patch adds support for finding those new ACLs as well as tests to verify the correct behavior. Reviewers: David Arthur <mumrah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode.
We're missing updating new resourcePatterns while migrating ACL metadata from
snapshot to Zk. Fixed and added a test to verify the correct behavior.