Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15015: Explicit on reload4j version #13745

Merged
merged 1 commit into from May 24, 2023
Merged

Conversation

atu-sharm
Copy link
Contributor

Defining a specific version for reload4j

@atu-sharm
Copy link
Contributor Author

@showuon @mimaison can you review?

@showuon
Copy link
Contributor

showuon commented May 23, 2023

@atu-sharm , could you run these commands to show what's the output of the lib folder for reload library?

// build the binary artifacts
$ ./gradlewAll releaseTarGz

// unpack the binary artifact 
$ tar xf core/build/distributions/kafka_2.13-X.Y.Z.tgz
$ cd xf kafka_2.13-X.Y.Z

// list the packaged jars 
$ ls libs | grep reload

Thanks.

@atu-sharm
Copy link
Contributor Author

Output:

reload4j-1.2.25.jar
slf4j-reload4j-1.7.36.jar

Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Will merge it after CI build completed.

@showuon
Copy link
Contributor

showuon commented May 24, 2023

Failed tests also failed in trunk build

    Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
    Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
    Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
    Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
    Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
    Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()
    Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
    Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
    Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
    Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
    Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()

@showuon showuon merged commit 87c9fd9 into apache:trunk May 24, 2023
1 check failed
showuon pushed a commit that referenced this pull request May 24, 2023
Defining a specific version for reload4j

Reviewers: Luke Chen <showuon@gmail.com>
showuon pushed a commit that referenced this pull request May 24, 2023
Defining a specific version for reload4j

Reviewers: Luke Chen <showuon@gmail.com>
@showuon
Copy link
Contributor

showuon commented May 24, 2023

Backported to 3.4 and 3.5 branch. @mimaison , if you have another RC build, this duplicated reload4j binary issue will be fixed. FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants