KAFKA-15036: Add a test case for controller failover #13777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@showuon @KarboniteKream @hachikuji I think this bug is very serious since it will stop any leader failover from functioning normally, so please take a look as soon as possible. |
KarboniteKream
approved these changes
May 30, 2023
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
Outdated
Show resolved
Hide resolved
soarez
reviewed
May 30, 2023
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
Outdated
Show resolved
Hide resolved
dengziming
commented
May 31, 2023
There was a problem hiding this comment.
Thanks for your comments @soarez @KarboniteKream , I have fixed them. @cmccabe do you have some suggestions for this change, you are familiar with the changes in QuorumController and ControllerServer.
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
Outdated
Show resolved
Hide resolved
| @@ -96,6 +96,32 @@ class KRaftClusterTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| def testCreateClusterAndRestartControllerNode(): Unit = { | |||
There was a problem hiding this comment.
@soarez Yes, we shutdown the active controller, then restart it to make it send ApiVersionRequest to a standby controller.
|
this will be fixed in #13799 |
dengziming
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
We introduced a bug when updating
handleApiVersionRequestbut it's not detected by CI, the bug has been fixed and we should add a test case for controller failover.Summary of testing strategy (including rationale)
KRaftClusterTest.testCreateClusterAndRestartControllerNode()
Committer Checklist (excluded from commit message)