Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-15039: Reduce logging level to trace in PartitionChangeBuilder.… #13780

Merged
merged 4 commits into from
May 31, 2023
Merged

KAFKA-15039: Reduce logging level to trace in PartitionChangeBuilder.… #13780

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3470928
KAFKA-15039: Reduce logging level to trace in PartitionChangeBuilder.…
rondagostino May 30, 2023
a00fe5a
WARN level for unclean elections
rondagostino May 30, 2023
c84ec42
Log unclean elections at INFO level
rondagostino May 31, 2023
9c3742f
Remove if (log.isTraceEnabled())
rondagostino May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 21 additions & 8 deletions metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,24 @@ private boolean isValidNewLeader(int replica) {
private void tryElection(PartitionChangeRecord record) {
ElectionResult electionResult = electLeader();
if (electionResult.node != partition.leader) {
log.debug(
"Setting new leader for topicId {}, partition {} to {} using {} election",
topicId,
partitionId,
electionResult.node,
electionResult.unclean ? "an unclean" : "a clean"
);
// generating log messages for partition elections can get expensive on large clusters,
// so only log clean elections at TRACE level;
// log unclean elections at WARN level since doing so can lead to data loss.
if (electionResult.unclean) {
log.warn(
Copy link
Contributor

@hachikuji hachikuji May 31, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about INFO level? Unclean election is "expected behavior" if it is enabled or requested specifically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good. Will adjust.

"Setting new leader for topicId {}, partition {} to {} using an unclean election",
topicId,
partitionId,
electionResult.node
);
} else if (log.isTraceEnabled()) {
log.trace(
"Setting new leader for topicId {}, partition {} to {} using a clean election",
topicId,
partitionId,
electionResult.node
);
}
record.setLeader(electionResult.node);
if (electionResult.unclean) {
// If the election was unclean, we have to forcibly set the ISR to just the
Expand All @@ -239,7 +250,9 @@ private void tryElection(PartitionChangeRecord record) {
}
}
} else {
log.debug("Failed to find a new leader with current state: {}", this);
if (log.isTraceEnabled()) {
log.trace("Failed to find a new leader with current state: {}", this);
}
}
}

Expand Down