Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: reorder collaborator #13790

Merged
merged 3 commits into from
Jun 1, 2023
Merged

MINOR: reorder collaborator #13790

merged 3 commits into from
Jun 1, 2023

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Jun 1, 2023

updated:
reorder collaborator list and hope the invitation can be resent!

===

update collaborator while releasing v3.4.1.

 git shortlog --email --numbered --summary --since=2022-06-01

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

- divijvaidya
- lucasbru
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucas is now a committer, removing him from the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is another Lucas. I might be mistaken, but lucasbru seems to be Lucas Brutschy, while it is Lucas Bradstreet the one with commit rights.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlprat is correct. This is a different Lucas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, updated now. Thanks.

.asf.yaml Outdated
- divijvaidya
- lucasbru
- yashmayya
- philipnee
- vamossagar12
- clolov
- fvaleri
- andymg3
- akhileshchg
Copy link
Contributor

@jlprat jlprat Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any decision on expiration date for this rights? If I understand the process right, it might be that andymg3 won't have the collaborator rights any more. Maybe infra doesn't revoke grants, that I don't know.

Copy link
Contributor Author

@showuon showuon Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, either. But as the doc mentioned:

The list will be updated as part of the major/minor release process, three to four times a year.

I have to update it for v3.4.1 release.

@dajac
Copy link
Contributor

dajac commented Jun 1, 2023

I wonder if we should wait until the next major release (3.6) before updating it given that we put this list together 2-3 weeks ago. It is a bit weird to already remove folks now.

@jlprat
Copy link
Contributor

jlprat commented Jun 1, 2023

We could just do the reordering, to see if the invites are sent again (for the 2 that didn't accept in time)

@showuon
Copy link
Contributor Author

showuon commented Jun 1, 2023

I wonder if we should wait until the next major release (3.6) before updating it given that we put this list together 2-3 weeks ago. It is a bit weird to already remove folks now.

Hmm... yes, it's only less than one month since we updated the list. Agree! Let's close this PR now and wait for v3.5.1 or v3.6.0 to update it.

cc @satishd who is the release manager of v3.6.0.

@cadonna
Copy link
Contributor

cadonna commented Jun 1, 2023

I would also opt for major releases. Minor releases are usually done around major releases and sometimes we also do multiple minor releases around a major release. So we would update the list quite often.

I am also wondering what happens to the people that are dropped from the list.

@showuon showuon closed this Jun 1, 2023
@jlprat
Copy link
Contributor

jlprat commented Jun 1, 2023

@showuon we could still do the reordering to see if the invites are sent again

@showuon showuon reopened this Jun 1, 2023
@showuon
Copy link
Contributor Author

showuon commented Jun 1, 2023

@showuon we could still do the reordering to see if the invites are sent again

Let's give it a try!

Copy link
Contributor

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@showuon showuon changed the title MINOR: update collaborator (v3.4.1 release) MINOR: reorder collaborator Jun 1, 2023
@showuon showuon merged commit e331729 into apache:trunk Jun 1, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants