-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: reorder collaborator #13790
MINOR: reorder collaborator #13790
Conversation
- divijvaidya | ||
- lucasbru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lucas is now a committer, removing him from the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is another Lucas. I might be mistaken, but lucasbru
seems to be Lucas Brutschy, while it is Lucas Bradstreet the one with commit rights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlprat is correct. This is a different Lucas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, updated now. Thanks.
.asf.yaml
Outdated
- divijvaidya | ||
- lucasbru | ||
- yashmayya | ||
- philipnee | ||
- vamossagar12 | ||
- clolov | ||
- fvaleri | ||
- andymg3 | ||
- akhileshchg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there any decision on expiration date for this rights? If I understand the process right, it might be that andymg3
won't have the collaborator rights any more. Maybe infra doesn't revoke grants, that I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, either. But as the doc mentioned:
The list will be updated as part of the major/minor release process, three to four times a year.
I have to update it for v3.4.1 release.
I wonder if we should wait until the next major release (3.6) before updating it given that we put this list together 2-3 weeks ago. It is a bit weird to already remove folks now. |
We could just do the reordering, to see if the invites are sent again (for the 2 that didn't accept in time) |
Hmm... yes, it's only less than one month since we updated the list. Agree! Let's close this PR now and wait for v3.5.1 or v3.6.0 to update it. cc @satishd who is the release manager of v3.6.0. |
I would also opt for major releases. Minor releases are usually done around major releases and sometimes we also do multiple minor releases around a major release. So we would update the list quite often. I am also wondering what happens to the people that are dropped from the list. |
@showuon we could still do the reordering to see if the invites are sent again |
Let's give it a try! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
updated:
reorder collaborator list and hope the invitation can be resent!
===
update collaborator while releasing v3.4.1.
Committer Checklist (excluded from commit message)