Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14462; [15/N] Make Result generic and rename it #13793

Merged
merged 1 commit into from Jun 2, 2023

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Jun 1, 2023

This patch makes the record type generic, moves the class to the runtime package and finally rename the class to follow the naming of the other classes in the runtime package.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jolshan
Copy link
Contributor

jolshan commented Jun 1, 2023

Can we update the description to give the rationale for this change?

@dajac
Copy link
Contributor Author

dajac commented Jun 1, 2023

@jolshan Updated the description. This is basically a minor refactoring.

Copy link
Contributor

@CalvinConfluent CalvinConfluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dajac dajac merged commit 7c3a284 into apache:trunk Jun 2, 2023
1 check failed
@dajac dajac deleted the KAFKA-14462-15 branch June 2, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants