KAFKA-14462; [16/N] Add CoordinatorLoader and CoordinatorPlayback interfaces #13794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Let's add a brief description to explain the rationale for these interfaces to the description |
jolshan
reviewed
Jun 1, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/Replayable.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * The Replayable interface. | ||
| */ | ||
| public interface Replayable<U> { |
There was a problem hiding this comment.
Do we want to name it more specifically to the coordinators?
There was a problem hiding this comment.
I have renamed it to CoordinatorPlayback. Does it sound good to you?
dajac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the CoordinatorLoader and the CoordinatorPlayback interfaces. The former is used to load (or rebuild) the coordinator state by replaying all the records stored in the partition. The later is the interface that must be implemented by coordinator to support replaying records.
Committer Checklist (excluded from commit message)