Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15048: Improve handling of unexpected quorum controller errors #13799

Merged
merged 2 commits into from
Jun 2, 2023

Commits on Jun 1, 2023

  1. KAFKA-15048: Improve handling of unexpected quorum controller errors

    When the active quorum controller encounters an "unexpected" error, such as a NullPointerException,
    it currently resigns its leadership. This PR fixes it so that in addition to doing that, it also
    increments the metadata error count metric. This will allow us to better track down these errors.
    
    This PR also fixes a minor bug where performing read operations on a standby controller would
    result in an unexpected RuntimeException. The bug happened because the standby controller does not
    take in-memory snapshots, and read operations were attempting to read from the epoch of the latest
    committed offset. The fix is for the standby controller to simply read the latest value of each
    data structure. This is always safe, because standby controllers don't contain uncommitted data.
    
    Also, fix a bug where listPartitionReassignments was reading the latest data, rather than data from
    the last committed offset.
    cmccabe committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ca2b1f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. address review comments

    cmccabe committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    437199d View commit details
    Browse the repository at this point in the history