-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Move Timer/TimingWheel to server-common #13820
Conversation
server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimer.java
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimer.java
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTask.java
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTask.java
Show resolved
Hide resolved
@divijvaidya As you started reviewing it, are you interested in finishing the review? That would unblock me. |
Hi @dajac , yes let me take a look first thing tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the non test files so far. Leaving early feedback while I look at the test files.
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTaskList.java
Outdated
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTaskList.java
Outdated
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTaskEntry.java
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTaskEntry.java
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/util/timer/TimingWheel.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test files look good. One minor comment.
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTask.java
Outdated
Show resolved
Hide resolved
@divijvaidya Thanks for your review. I have addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The code is consistent with the scala implementation. I haven't reviewed for logical bugs but that is out of scope of this PR.
(waiting for CI test run to complete before approving)
Failed tests seem unrelated:
|
This patch rewrites MockTimer in Java and moves it from core to server-common. This continues the work started in #13820. Reviewers: Divij Vaidya <diviv@amazon.com>
This patch rewrite
Timer
and the related classes in Java and moves them toserver-common
module. It is basically a one to one rewrite of the Scala code. Note thatMockTimer
is not moved as part of this patch. It will be done separately.Committer Checklist (excluded from commit message)