KAFKA-15078; KRaft leader replys with snapshot for offset 0 #13845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the follower has an empty log, fetches with offset 0, it is more efficient for the leader to reply with a snapshot id (redirect to FETCH_SNAPSHOT) than for the follower to continue fetching from the log segments.
jsancio
commented
Jun 12, 2023
| } | ||
|
|
||
| @Test | ||
| public void testFetchRequestOffsetAtZero() throws Exception { |
There was a problem hiding this comment.
This test fails against trunk.
dengziming
reviewed
Jun 14, 2023
|
|
||
| Optional<OffsetAndEpoch> latestSnapshotId = log.latestSnapshotId(); | ||
| final ValidOffsetAndEpoch validOffsetAndEpoch; | ||
| if (fetchOffset == 0 && latestSnapshotId.isPresent()) { |
There was a problem hiding this comment.
I have tried to figure out some other cases we prefer to read the snapshot, a common case is highWatermark - fetchOffset > count(snapshot record). Do you think it's possible to write count(snapshot record) in the snapshot header?
There was a problem hiding this comment.
Thanks @dengziming
We had a similar conversation in another PR: #13834 (comment)
In short, it is not clear to me that these improvements (implementation complexities) are a big win for the cluster metadata partition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the follower has an empty log, fetches with offset 0, it is more efficient for the leader to reply with a snapshot id (redirect to FETCH_SNAPSHOT) than for the follower to continue fetching from the log segments.
Committer Checklist (excluded from commit message)