New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests #13859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None): | |||
self.wait_until_rejoin() | |||
|
|||
@cluster(num_nodes=6) | |||
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"]) | |||
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"]) | |||
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question because I have been going into this part of the codebase - is there a reason why the other two compression types are not tested (i.e. gzip, zstd)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I don't know. At this point, we've copied the same lines as the previous releases. Maybe this could be improved. If so I'd rather separate it from this PR and handle this out of a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I agree, this definitely needs to not be in this pull request, I was just wondering in case the answer was on top of your head
You can ignore this, I saw that it is updated as part of another pull request. |
…stem tests (apache#13859) Reviewers: Luke Chen <showuon@gmail.com>, Christo Lolov <christololov@gmail.com>
Committer Checklist (excluded from commit message)