Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests #13859

Merged
merged 1 commit into from Jul 12, 2023

Conversation

mimaison
Copy link
Member

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()

@cluster(num_nodes=6)
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general question because I have been going into this part of the codebase - is there a reason why the other two compression types are not tested (i.e. gzip, zstd)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't know. At this point, we've copied the same lines as the previous releases. Maybe this could be improved. If so I'd rather separate it from this PR and handle this out of a release.

Copy link
Collaborator

@clolov clolov Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I agree, this definitely needs to not be in this pull request, I was just wondering in case the answer was on top of your head

@clolov
Copy link
Collaborator

clolov commented Jun 21, 2023

I believe this (https://github.com/apache/kafka/blob/trunk/tests/kafkatest/version.py#L246-L248) should be changed to

...
V_3_4_1 = KafkaVersion("3.4.1")
LATEST_3_4 = V_3_4_1

as part of this pull request, no?

You can ignore this, I saw that it is updated as part of another pull request.

@mimaison mimaison merged commit b584e91 into apache:trunk Jul 12, 2023
1 check failed
@mimaison mimaison deleted the KAFKA-15093-core branch July 12, 2023 08:37
Cerchie pushed a commit to Cerchie/kafka that referenced this pull request Jul 25, 2023
…stem tests (apache#13859)


Reviewers: Luke Chen <showuon@gmail.com>, Christo Lolov  <christololov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants