Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime #13961

Merged
merged 5 commits into from Jul 7, 2023
Merged

KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime #13961

merged 5 commits into from Jul 7, 2023

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Jul 5, 2023 •
edited

This patch adds the implementation of the CoordinatorTimer.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 label Jul 5, 2023
@dajac dajac force-pushed the KAFKA-14462-21 branch 3 times, most recently from e03330f to 06bc842 Compare July 5, 2023 16:39
@dajac dajac marked this pull request as ready for review July 5, 2023 16:40
jolshan
jolshan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jolshan jolshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all my confusions 😅 lgtm

@dajac dajac merged commit 9cde3a7 into apache:trunk Jul 7, 2023
1 check failed
@dajac dajac deleted the KAFKA-14462-21 branch July 7, 2023 20:21
jeffkbkim
jeffkbkim approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jeffkbkim jeffkbkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! left a minor suggestion.

...coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java Show resolved Hide resolved
...coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkbkim jeffkbkim jeffkbkim approved these changes

@jolshan jolshan jolshan approved these changes

Assignees
No one assigned
Labels
KIP-848
Projects
None yet
Milestone
No milestone
3 participants
@dajac @jeffkbkim @jolshan