Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-15150: Add ServiceLoaderScanner implementation #13971

Merged
merged 17 commits into from
Jul 19, 2023
Merged

KAFKA-15150: Add ServiceLoaderScanner implementation #13971

merged 17 commits into from
Jul 19, 2023

Commits on Jul 6, 2023

  1. KAFKA-15150: Add ServiceLoaderScanner implementation 

    This reverts commit 7c0e312.
    @gharris1727
    gharris1727 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6a530b6 View commit details
    Browse the repository at this point in the history

  2. Add TestPlugins serviceloader manifests

    @gharris1727
    gharris1727 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2a3026f View commit details
    Browse the repository at this point in the history

  3. Paramterize PluginScannerTest to apply tests to ServiceLoaderScanner 

    This reverts commit bf4f03b.
    @gharris1727
    gharris1727 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    31afb6e View commit details
    Browse the repository at this point in the history

  4. fixup: remove DelegatingClassLoader from PluginScannerTest 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b2d5fb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. fixup: add missing bad-packaging manifests 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4e08343 View commit details
    Browse the repository at this point in the history

  2. fixup: stronger test assertions, review comments 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5ba55c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. fixup: retry Iterator#hasNext on LinkageError 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7803cfe View commit details
    Browse the repository at this point in the history

  2. fixup: add class can be loaded to javadoc descriptions 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0601c7d View commit details
    Browse the repository at this point in the history

  3. fixup: JDK8 compatibility where LinkageError is thrown from Iterator#… 

    …next

Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c71dd39 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. fixup: be defensive about all ServiceLoader LinkageErrors 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    70194a0 View commit details
    Browse the repository at this point in the history

  2. fixup: remove duplicate error handling 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4768fdf View commit details
    Browse the repository at this point in the history

  3. fixup: change ClassLoader to PluginSource throughout PluginScanner fo… 

    …r better log messages

Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0c2fd04 View commit details
    Browse the repository at this point in the history

  4. fixup: change signatures in ServiceLoaderScanner 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    367bd1d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. fixup: use non-null sentinel path for PluginSource to improve log sta… 

    …tements

Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cfd1973 View commit details
    Browse the repository at this point in the history

  2. fixup: change log messages 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9071d90 View commit details
    Browse the repository at this point in the history

  3. fixup: remove handleLinkageError calls on load/iterator 

    Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7f9585e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge remote-tracking branch 'upstream/trunk' into kafka-15150-servic… 

    …e-loader-scanner

Signed-off-by: Greg Harris <greg.harris@aiven.io>
    @gharris1727
    gharris1727 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    6ae92b9 View commit details
    Browse the repository at this point in the history