KAFKA-15148: Some integration tests are running as unit tests #13973
Conversation
eziosudo
changed the title
eziosudo
changed the title
|
@divijvaidya Hi, can you help to review this PR? |
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
Thank you for addressing the comments. Are the results in the description updated after the latest change? If not, can you please update them. My motivation of asking this is to ensure that we are not accidentally removing the tests from running in either unitTest or integTests. |
…egration") exclude integration tests in "./gradlew unitTest" by adding @category(IntegrationTest.class)
eziosudo
force-pushed
the
KAFKA-15148_tag_integration_ut
branch
from
b0fb50f
to
6479d5c
Compare
I agree. We shall be careful with every merge. So I run all the tests agian. These are integration tests in trunk branch after running './gradlew unitTest': In my branch I run './gradlew unitTest' then filter integration tests and got nothing, which means integration cases are excluded. After run './gradle integrationTest' in my branch, I get all the integration tests I changed in this PR, which means they are all included. |
|
Thank you for the change. I have verified that the modified tests are running as part of the CI as well. Merging in. |
…ning as unit tests (apache#13973) Reviewers: Divij Vaidya <diviv@amazon.com>
Change these tests by adding @tag("integration") and @category(IntegrationTest.class).
./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.MetricsReporterIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.LagFetchIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.OptimizedKTableIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.RegexSourceIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.StandbyTaskCreationIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.MetricsIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.KTableKTableForeignKeyInnerJoinMultiIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.KTableKTableForeignKeyJoinDistributedTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.QueryableStateIntegrationTest.html ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.KTableEfficientRangeQueryTest.html ./connect/runtime/build/reports/tests/unitTest/classes/org.apache.kafka.connect.integration.StartAndStopCounterTest.html ./connect/runtime/build/reports/tests/unitTest/classes/org.apache.kafka.connect.integration.StartAndStopLatchTest.html"stream" module's unitTest time reduced from 25 minutes to 17 minutes, "connect" module's unitTest time reduced from 18 minutes to 12 minutes.
Committer Checklist (excluded from commit message)