KAFKA-1782: Follow up - add missing @Test annotations. #140
Conversation
|
@guozhangwang @hachikuji I'm pretty sure I managed to get all of them... |
|
kafka-trunk-git-pr #146 FAILURE |
|
@ewencp is this relevant? kafka.controller.ControllerFailoverTest > testMetadataUpdate FAILED |
|
Good catch, I unfortunately missed that because those SocketServerTests are always failing for me, so I expect those error messages at the end of my test run currently... This was due to a test that was written before the patch was applied but then applied via rebase + squash after the patch was applied. We'll need to watch out for these for a bit with the github PRs since you can issue a PR without having merged back with trunk (so if you just check out the branch it might pass the tests, but will fail when actually committed). I'm not sure if the jenkins build does a merge with trunk before running the build or not, which would protect against this... |
|
kafka-trunk-git-pr #147 SUCCESS |
|
Thanks, LGTM! |
|
@ewencp The usual behaviour for the PR plugin is to merge with trunk indeed (I have been surprised by this behaviour in the past when having different results in the Jenkins PR builder when compared to running tests locally for that branch). Having said that, I don't know how the PR builder for Kafka is configured since it uses the less popular Cloudbees PR builder. |
…controller requests (apache#140) TICKET = N/A LI_DESCRIPTION = This is the 2nd PR to implement the feature of control request merging laid out in the design doc https://docs.google.com/document/d/1PZAOwpw09tVDeuSP0OBVhB6dbgz7C7dQU6bRkePQ8qg/edit Specifically, this PR includes 1. adding the ControllerRequestMerger for merging controller requests 2. adding methods in existing classes so that their fields can be accessed. This includes AbstractControlRequest, LeaderAndIsrRequest, UpdateMetadataRequest, StopReplicaRequest 3. adding a utility class LiCombinedControlTransformer to convert the data format between the LiCombinedControl request/response and the existing controller request types EXIT_CRITERIA = It's unclear whether this feature should be put in upstream apache kafka yet. If we decide to put this change upstream, the exit criteria will be when it gets merged upstream and pulled in a part of a release.
…controller requests (apache#140) TICKET = N/A LI_DESCRIPTION = This is the 2nd PR to implement the feature of control request merging laid out in the design doc https://docs.google.com/document/d/1PZAOwpw09tVDeuSP0OBVhB6dbgz7C7dQU6bRkePQ8qg/edit Specifically, this PR includes 1. adding the ControllerRequestMerger for merging controller requests 2. adding methods in existing classes so that their fields can be accessed. This includes AbstractControlRequest, LeaderAndIsrRequest, UpdateMetadataRequest, StopReplicaRequest 3. adding a utility class LiCombinedControlTransformer to convert the data format between the LiCombinedControl request/response and the existing controller request types EXIT_CRITERIA = It's unclear whether this feature should be put in upstream apache kafka yet. If we decide to put this change upstream, the exit criteria will be when it gets merged upstream and pulled in a part of a release.
…controller requests (apache#140) TICKET = N/A LI_DESCRIPTION = This is the 2nd PR to implement the feature of control request merging laid out in the design doc https://docs.google.com/document/d/1PZAOwpw09tVDeuSP0OBVhB6dbgz7C7dQU6bRkePQ8qg/edit Specifically, this PR includes 1. adding the ControllerRequestMerger for merging controller requests 2. adding methods in existing classes so that their fields can be accessed. This includes AbstractControlRequest, LeaderAndIsrRequest, UpdateMetadataRequest, StopReplicaRequest 3. adding a utility class LiCombinedControlTransformer to convert the data format between the LiCombinedControl request/response and the existing controller request types EXIT_CRITERIA = It's unclear whether this feature should be put in upstream apache kafka yet. If we decide to put this change upstream, the exit criteria will be when it gets merged upstream and pulled in a part of a release.
…controller requests (apache#140) TICKET = N/A LI_DESCRIPTION = This is the 2nd PR to implement the feature of control request merging laid out in the design doc https://docs.google.com/document/d/1PZAOwpw09tVDeuSP0OBVhB6dbgz7C7dQU6bRkePQ8qg/edit Specifically, this PR includes 1. adding the ControllerRequestMerger for merging controller requests 2. adding methods in existing classes so that their fields can be accessed. This includes AbstractControlRequest, LeaderAndIsrRequest, UpdateMetadataRequest, StopReplicaRequest 3. adding a utility class LiCombinedControlTransformer to convert the data format between the LiCombinedControl request/response and the existing controller request types EXIT_CRITERIA = It's unclear whether this feature should be put in upstream apache kafka yet. If we decide to put this change upstream, the exit criteria will be when it gets merged upstream and pulled in a part of a release.
No description provided.