KAFKA-14499: [2/N] Add OffsetCommit record & related #14047
Merged
+409
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
commented
Jul 19, 2023
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java
Outdated
Show resolved
Hide resolved
dajac
commented
Jul 19, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java
Outdated
Show resolved
Hide resolved
dajac
commented
Jul 19, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java
Show resolved
Hide resolved
jolshan
reviewed
Jul 19, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java
Show resolved
Hide resolved
jolshan
reviewed
Jul 19, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java
Show resolved
Hide resolved
mumrah
reviewed
Jul 20, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java
Outdated
Show resolved
Hide resolved
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java
Show resolved
Hide resolved
jeffkbkim
reviewed
Jul 21, 2023
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java
Show resolved
Hide resolved
|
Failed tests are unrelated. Merging to trunk. |
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
This patch does a few things: 1) It introduces the `OffsetAndMetadata` class which hold the committed offsets in the group coordinator. 2) It adds methods to deal with OffsetCommit records to `RecordHelpers`. 3) It adds `MetadataVersion#offsetCommitValueVersion` to get the version of the OffsetCommit value record that should be used. Reviewers: Jeff Kim <jeff.kim@confluent.io>, David Arthur <mumrah@gmail.com>, Justine Olshan <jolshan@confluent.io>
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
This patch does a few things: 1) It introduces the `OffsetAndMetadata` class which hold the committed offsets in the group coordinator. 2) It adds methods to deal with OffsetCommit records to `RecordHelpers`. 3) It adds `MetadataVersion#offsetCommitValueVersion` to get the version of the OffsetCommit value record that should be used. Reviewers: Jeff Kim <jeff.kim@confluent.io>, David Arthur <mumrah@gmail.com>, Justine Olshan <jolshan@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a few things:
OffsetAndMetadataclass which hold the committed offsets in the group coordinator.RecordHelpers.MetadataVersion#offsetCommitValueVersionto get the version of the OffsetCommit value record that should be used.Committer Checklist (excluded from commit message)