Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898) #14068

Merged
merged 11 commits into from Aug 10, 2023
Merged

KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898) #14068

merged 11 commits into from Aug 10, 2023

Conversation

gharris1727
Copy link
Contributor

This is a restatement of the contents of KIP-898, geared towards a wider audience.
This documentation is linked from error messages in #14055.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@gharris1727
KAFKA-15233: Add documentation for plugin.discovery and connect-plugi…
f25d518 
…n-path (KIP-898)

Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727 gharris1727 mentioned this pull request Jul 21, 2023
Merged
3 tasks
@gharris1727 gharris1727 added connect kip Requires or implements a KIP labels Jul 21, 2023
@C0urante C0urante added the docs label Jul 24, 2023
@gharris1727
fixup: rewrite everything for second draft
8e222f8 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: link typo
18523e2 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: link typo
e41a355 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
C0urante
C0urante reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg! Great to see docs for this feature, it's vital that we make it easy for users to understand if we want widespread adoption and, in the future, to change the default mode to SERVICE_LOAD.

docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
@gharris1727
fixup: review comments/third draft
5c3e350 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: typos
667a585 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
C0urante
C0urante reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg! Really appreciate the thoughtful discussion here.

docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
docs/connect.html Outdated Show resolved Hide resolved
@gharris1727
fixup: review comments
4d10017 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: reword and shorten lines
85db0e9 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
C0urante
C0urante approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Greg.

@gharris1727
fixup: antecedent
470c4dc 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: typo
ec7ca3a 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
fixup: small wording change
641ddb7 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727 gharris1727 merged commit 821954e into apache:trunk Aug 10, 2023
1 check was pending
jeqo pushed a commit to aiven/kafka that referenced this pull request Aug 15, 2023
@gharris1727 @jeqo
KAFKA-15233: Add documentation for plugin.discovery and connect-plugi…
f942f46 
…n-path (KIP-898) (apache#14068)

Reviewers: Qichao Chu (@ex172000), Chris Egerton <chrise@aiven.io>
jeqo pushed a commit to jeqo/kafka that referenced this pull request Aug 15, 2023
@gharris1727 @jeqo
KAFKA-15233: Add documentation for plugin.discovery and connect-plugi…
48016d6 
…n-path (KIP-898) (apache#14068)

Reviewers: Qichao Chu (@ex172000), Chris Egerton <chrise@aiven.io>
jeqo pushed a commit to jeqo/kafka that referenced this pull request Aug 15, 2023
@gharris1727 @jeqo
KAFKA-15233: Add documentation for plugin.discovery and connect-plugi…
d379a42 
…n-path (KIP-898) (apache#14068)

Reviewers: Qichao Chu (@ex172000), Chris Egerton <chrise@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ex172000 ex172000 ex172000 approved these changes

@C0urante C0urante C0urante approved these changes

Assignees
No one assigned
Labels
connect docs kip Requires or implements a KIP
Projects
None yet
Milestone
No milestone
3 participants
@gharris1727 @ex172000 @C0urante