Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest #14102

Merged
merged 20 commits into from
Aug 10, 2023
Merged

KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest #14102

merged 20 commits into from
Aug 10, 2023

Commits on Jul 26, 2023

  1. KAFKA-13187: Replace EasyMock / PowerMock with Mockito in Distributed… 

    …HerderTest
    @yashmayya
    yashmayya committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d77a997 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Modify DistributedHerder testing constructor to use array instead of … 

    …varargs to work around Mockito issue; remove DistributedHerderTest from JDK >= 16 exclude list
    @yashmayya
    yashmayya committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    410f9f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Clarify intent of testRebalance using appropriate spacing and an addi… 

    …tional comment
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    43f69ea View commit details
    Browse the repository at this point in the history

  2. Similar spacing changes elsewhere

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    fd0f339 View commit details
    Browse the repository at this point in the history

  3. Add additional verification between ticks to verify number of calls t… 

    …o startConnector, connectorTaskConfigs, startSourceTask
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    20b3e72 View commit details
    Browse the repository at this point in the history

  4. Add verification for call to Worker::stopAndAwaitConnector in revokeA… 

    …ndReassign
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8fab536 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary additional tick in testCreateConnectorFailedValida… 

    …tion and testCreateConnectorAlreadyExists
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9c648ad View commit details
    Browse the repository at this point in the history

  6. Add additional verification for number of times the connector is stop… 

    …ped (once) in testRestartConnector
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cc08bb1 View commit details
    Browse the repository at this point in the history

  7. Verify no more interactions with the RestartPlan mocks in restart tests

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9873ee3 View commit details
    Browse the repository at this point in the history

  8. Update herder config snapshot in testDoRestartConnectorAndTasksOnlyCo… 

    …nnector to ensure connector isn't started with null config
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3315f6b View commit details
    Browse the repository at this point in the history

  9. Check that the connector / task statuses are updated to RESTARTING in… 

    … new restart API tests
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6d5ab06 View commit details
    Browse the repository at this point in the history

  10. Add additional verification for number of times the task is stopped (… 

    …once) in testRestartTask
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    022ac0a View commit details
    Browse the repository at this point in the history

  11. Use expectConfigRefreshAndSnapshot in testConnectorConfigAdded

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3ce2592 View commit details
    Browse the repository at this point in the history

  12. Fix semantics of testConnectorConfigAdded and testTaskConfigAdded

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    73b7194 View commit details
    Browse the repository at this point in the history

  13. Make poll verifications directly after tick calls in key rotation tests

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    315b780 View commit details
    Browse the repository at this point in the history

  14. Verify no more interactions with putTaskConfigs callback in request s… 

    …igning test cases
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    4f0dff6 View commit details
    Browse the repository at this point in the history

  15. Remove now redundant comment in testExternalZombieFencingRequestDelay… 

    …edCompletion
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cbddfac View commit details
    Browse the repository at this point in the history

  16. Explicitly verify that there is a single fence zombies call made per … 

    …connector in testExternalZombieFencingRequestDelayedCompletion
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b71c288 View commit details
    Browse the repository at this point in the history

  17. Verify no more interactions with rest client in expectAndVerifyTaskRe… 

    …configurationRetries
    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    12e647f View commit details
    Browse the repository at this point in the history

  18. Remove redundant expectAnyTicks method

    @yashmayya
    yashmayya committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    98d7be1 View commit details
    Browse the repository at this point in the history