Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-15189: only init remote topic metrics when enabled #14133
KAFKA-15189: only init remote topic metrics when enabled #14133
Changes from 4 commits
e7fa43e
6f7a39c
f7696e8
6b76e3b
9efb0e2
aa89b79
7ba060c
3241b60
5dc462b
c0536c8
4987727
4f37d9c
4c2d335
86ed825
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this enable RemoteStorage for all tests which use
@Parameterized
(and not just for testMetrics)? An alternative way is to add the full test name here OR check for string "systemRemoteStorageEnabled: true".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! Currently there's only 1 test in this test suite, but we should make it much clear. Updating now.