New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-15189: only init remote topic metrics when enabled #14133
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e7fa43e
KAFKA-15189: only init remote topic metrics when enabled
showuon 6f7a39c
KAFKA-15189: pass config into brokerTopicStats
showuon f7696e8
KAFKA-15189: add integration tests
showuon 6b76e3b
KAFKA-15189: verify all remote storage related metric
showuon 9efb0e2
KAFKA-15189: add class description
showuon aa89b79
KAFKA-15189: use RemoteStorageMetrics as source of truth
showuon 7ba060c
Merge branch 'trunk' of https://github.com/apache/kafka into KAFKA-15189
showuon 3241b60
KAFKA-15189: resolve conflict
showuon 5dc462b
KAFKA-15189: use metricName as source of truth
showuon c0536c8
KAFKA-15189: add test name into setup filter
showuon 4987727
KAFKA-15189: fix checkstyle error
showuon 4f37d9c
KAFKA-15189: fix scala 2.12 compilation error
showuon 4c2d335
KAFKA-15189: fix broken test
showuon 86ed825
Merge branch 'KAFKA-15189' of https://github.com/showuon/kafka into K…
showuon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,7 +127,7 @@ public class RemoteLogManagerTest { | |
RemoteStorageManager remoteStorageManager = mock(RemoteStorageManager.class); | ||
RemoteLogMetadataManager remoteLogMetadataManager = mock(RemoteLogMetadataManager.class); | ||
RemoteLogManagerConfig remoteLogManagerConfig = null; | ||
BrokerTopicStats brokerTopicStats = new BrokerTopicStats(); | ||
BrokerTopicStats brokerTopicStats = new BrokerTopicStats(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. force to true since we're testing |
||
RemoteLogManager remoteLogManager = null; | ||
|
||
TopicIdPartition leaderTopicIdPartition = new TopicIdPartition(Uuid.randomUuid(), new TopicPartition("Leader", 0)); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ | |
public class RemoteLogReaderTest { | ||
public static final String TOPIC = "test"; | ||
RemoteLogManager mockRLM = mock(RemoteLogManager.class); | ||
BrokerTopicStats brokerTopicStats = new BrokerTopicStats(); | ||
BrokerTopicStats brokerTopicStats = new BrokerTopicStats(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. force to true since we're testing |
||
LogOffsetMetadata logOffsetMetadata = new LogOffsetMetadata(100); | ||
Records records = mock(Records.class); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initializing brokerTopicStats if null, with the initialized config in L176 above.