KAFKA-15288: Change BrokerApiVersionsCommandTest to support kraft mode #14175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengziming
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Thank you for this PR @vveicc , I left some comments, PTAL.
clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/admin/BrokerApiVersionsCommandTest.scala
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/admin/BrokerApiVersionsCommandTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/admin/BrokerApiVersionsCommandTest.scala
Show resolved
Hide resolved
|
Thank you for your advice @dengziming, this is very helpful to me. I have made some changes, PTAL. |
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
apache#14175) Use ApiKeys.clientApis() to replace ApiKeys.zkBrokerApis() to support kraft mode. Reviewers: dengziming <dengziming1993@gmail.com>
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Aug 15, 2023
apache#14175) Use ApiKeys.clientApis() to replace ApiKeys.zkBrokerApis() to support kraft mode. Reviewers: dengziming <dengziming1993@gmail.com>
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Aug 15, 2023
apache#14175) Use ApiKeys.clientApis() to replace ApiKeys.zkBrokerApis() to support kraft mode. Reviewers: dengziming <dengziming1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change BrokerApiVersionsCommandTest to support kraft mode.
Committer Checklist (excluded from commit message)