Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-7438: Replace Easymock & Powermock with Mockito in TableSourceNodeTest #14189

Merged
merged 1 commit into from Aug 12, 2023
Merged

KAFKA-7438: Replace Easymock & Powermock with Mockito in TableSourceNodeTest #14189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 11 additions & 16 deletions ...s/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java
View file
Open in desktop
Expand Up @@ -23,41 +23,36 @@
import org.apache.kafka.streams.kstream.internals.MaterializedInternal;
import org.apache.kafka.streams.kstream.internals.graph.TableSourceNode.TableSourceNodeBuilder;
import org.apache.kafka.streams.processor.internals.InternalTopologyBuilder;
import org.easymock.EasyMock;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.powermock.api.easymock.PowerMock;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;

@RunWith(PowerMockRunner.class)
@PrepareForTest({InternalTopologyBuilder.class})
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;


@RunWith(MockitoJUnitRunner.StrictStubs.class)
public class TableSourceNodeTest {

private static final String STORE_NAME = "store-name";
private static final String TOPIC = "input-topic";

private final InternalTopologyBuilder topologyBuilder = PowerMock.createNiceMock(InternalTopologyBuilder.class);
@Mock
private InternalTopologyBuilder topologyBuilder;

@Test
public void shouldConnectStateStoreToInputTopicIfInputTopicIsUsedAsChangelog() {
final boolean shouldReuseSourceTopicForChangelog = true;
topologyBuilder.connectSourceStoreAndTopic(STORE_NAME, TOPIC);
EasyMock.replay(topologyBuilder);

buildTableSourceNode(shouldReuseSourceTopicForChangelog);

EasyMock.verify(topologyBuilder);
verify(topologyBuilder).connectSourceStoreAndTopic(STORE_NAME, TOPIC);
}

@Test
public void shouldConnectStateStoreToChangelogTopic() {
final boolean shouldReuseSourceTopicForChangelog = false;
EasyMock.replay(topologyBuilder);

buildTableSourceNode(shouldReuseSourceTopicForChangelog);

EasyMock.verify(topologyBuilder);
verify(topologyBuilder, never()).connectSourceStoreAndTopic(STORE_NAME, TOPIC);
}

private void buildTableSourceNode(final boolean shouldReuseSourceTopicForChangelog) {
Expand Down