KAFKA-10199: Change to RUNNING if no pending task to init exist #14214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadonna
commented
Aug 15, 2023
| @@ -53,9 +53,11 @@ public interface TasksRegistry { | |||
|
|
|||
| void addPendingTaskToCloseClean(final TaskId taskId); | |||
|
|
|||
| Set<Task> drainPendingTaskToInit(); | |||
| Set<Task> drainPendingTasksToInit(); | |||
cadonna
commented
Aug 15, 2023
|
|
||
| void addPendingTaskToInit(final Collection<Task> tasks); | ||
| void addPendingTasksToInit(final Collection<Task> tasks); |
cadonna
commented
Aug 15, 2023
| void addPendingTaskToInit(final Collection<Task> tasks); | ||
| void addPendingTasksToInit(final Collection<Task> tasks); | ||
|
|
||
| boolean hasPendingTasksToInit(); |
cadonna
commented
Aug 15, 2023
Comment on lines
+767
to
+769
| return !stateUpdater.restoresActiveTasks() | ||
| && !tasks.hasPendingTasksToRecycle() | ||
| && !tasks.hasPendingTasksToInit(); |
cadonna
commented
Aug 15, 2023
Comment on lines
849
to
+852
| // The state directory may still be locked by another thread, when the rebalance just happened. | ||
| // Retry in the next iteration. | ||
| log.info("Encountered lock exception. Reattempting locking the state in the next iteration.", lockException); | ||
| tasks.addPendingTaskToInit(Collections.singleton(task)); | ||
| tasks.addPendingTasksToInit(Collections.singleton(task)); |
There was a problem hiding this comment.
This is the code that required the fix.
lucasbru
approved these changes
Aug 15, 2023
|
I am not sure that this is the cause of the issue that I see. But in any case, it is not correct to change the state to |
A stream thread should only change to RUNNING if there are no active tasks in restoration in the state updater and if there are no pending tasks to recycle and to init. Usually all pending tasks to init are added to the state updater in the same poll iteration that handles the assignment. However, if during an initialization of a task a LockException the task is re-added to the tasks to init and initialization is retried in the next poll iteration. A LockException might occur when a state directory is still locked by another thread, when the rebalance just happened.
cadonna
force-pushed
the
change_to_running_if_no_pending_tasks_to_init
branch
from
acb2d46
to
a5699d0
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stream thread should only change to RUNNING if there are no active tasks in restoration in the state updater and if there are no pending tasks to recycle and to init.
Usually all pending tasks to init are added to the state updater in the same poll iteration that handles the assignment. However, if during an initialization of a task a LockException the task is re-added to the tasks to init and initialization is retried in the next poll iteration.
A LockException might occur when a state directory is still locked by another thread, when the rebalance just happened.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)