Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15338: The metric group documentation for metrics added in KAFK… #14221

Merged
merged 1 commit into from Sep 8, 2023

Conversation

atu-sharm
Copy link
Contributor

…A-13945 is incorrect

@atu-sharm
Copy link
Contributor Author

Hi @machi1990 @showuon @mimaison can you have a look at this

@mimaison
Copy link
Member

I'll delegate to Streams savvy people, @mjsax @vvcephei

@mjsax mjsax merged commit 9ecf6f7 into apache:trunk Sep 8, 2023
1 check failed
mjsax pushed a commit that referenced this pull request Sep 8, 2023
…A-13945 is incorrect (#14221)

Reviewers: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 8, 2023
…A-13945 is incorrect (#14221)

Reviewers: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 8, 2023
…A-13945 is incorrect (#14221)

Reviewers: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 8, 2023
…A-13945 is incorrect (#14221)

Reviewers: Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Member

mjsax commented Sep 8, 2023

Thanks for the PR @atu-sharm. Merged to trunk, and cherry-picked to 3.6, 3.5, 3.4, and 3.3 branches.

Could you also do a PR against https://github.com/apache/kafka-site and port this fix, so we get fix live on the web-page right away?

mjsax added a commit to mjsax/kafka-site that referenced this pull request Oct 13, 2023
@mjsax
Copy link
Member

mjsax commented Oct 13, 2023

Did a follow up PR to the webpage: apache/kafka-site#558

@atu-sharm
Copy link
Contributor Author

Thanks @mjsax, somehow missed the above comment

mjsax added a commit to apache/kafka-site that referenced this pull request Oct 13, 2023
Follow up to apache/kafka#14221

Reviewers: Lucas Brutschy <lbrutschy@confluent.io>
@mjsax
Copy link
Member

mjsax commented Oct 13, 2023

No problem :)

mjsax pushed a commit to confluentinc/kafka that referenced this pull request Nov 22, 2023
…A-13945 is incorrect (apache#14221)

Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants