Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15396:Add a metric indicating the version of the current running kafka server #14284

Closed
wants to merge 4 commits into from

Conversation

hudeqi
Copy link
Contributor

@hudeqi hudeqi commented Aug 24, 2023

  1. Add a kafka version metric indicating the version of the current running kafka server, it can help us to perceive the mixed distribution of multiple versions, and to perceive the progress of version upgrade in the cluster in real time.
  2. Remove forgotten metrics when broker shutdown.

@divijvaidya divijvaidya added the kip Requires or implements a KIP label Aug 24, 2023
@jolshan
Copy link
Contributor

jolshan commented Aug 25, 2023

Hey @hudeqi Divij asked on the JIRA if there is a KIP associated to this. Metrics changes require one.

@hudeqi
Copy link
Contributor Author

hudeqi commented Aug 28, 2023

This is KIP-972

@jolshan
Copy link
Contributor

jolshan commented Aug 29, 2023

I see in the discussion thread that there is such a metric but it is slightly different:
https://lists.apache.org/thread/1tn3jq1z4m2ycpo5l20ch3bw58wocrj9

We can take the discussion to the thread, but just wanted to confirm @hudeqi saw it.

@hudeqi
Copy link
Contributor Author

hudeqi commented Aug 30, 2023

Hi, I have saw the discussion thread. Maybe I need update the pr title to do the second thing in PR description. @jolshan

@hudeqi hudeqi marked this pull request as draft September 14, 2023 12:53
@hudeqi hudeqi marked this pull request as ready for review October 30, 2023 06:17
Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jan 29, 2024
@hudeqi hudeqi closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kip Requires or implements a KIP stale Stale PRs
Projects
None yet
3 participants