Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15307: Removes non-existent configs #14341

Merged

Conversation

Cerchie
Copy link
Contributor

@Cerchie Cerchie commented Sep 5, 2023

addresses 1/3 of https://issues.apache.org/jira/browse/KAFKA-15307

Removes pieces of configuration from the developer guide to configuring streams..

These were the pieces of configuration not found in StreamsConfig.java.

They include:

  • partition.grouper
  • rack.aware.assignment.tag
  • rocksdb.config.setter
  • state.dir
  • topology.optimization

Note: acks and replication.factor, although not found in 'StreamsConfig.java', are listed in the developer guide to configuring streams. I am assuming they are defined somewhere else.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@Cerchie
Copy link
Contributor Author

Cerchie commented Sep 5, 2023

@mjsax for review

@mjsax
Copy link
Member

mjsax commented Sep 7, 2023

Thanks for the PR. I know that we did remove partition.grouper, but the others seems to be valid config. For example https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L665

Can you double check again?

@Cerchie
Copy link
Contributor Author

Cerchie commented Sep 7, 2023

Thanks for the PR. I know that we did remove partition.grouper, but the others seems to be valid config. For example https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L665

Can you double check again?

huh. I wonder if was working from an un-updated fork-- double-checking.

EDIT: update-- just double-checked and replaced the configs that were not missing. It was only partition.grouper that needed removal.

@mjsax mjsax merged commit 01c7c7a into apache:trunk Sep 7, 2023
1 check was pending
mjsax pushed a commit that referenced this pull request Sep 7, 2023
`partition.grouper` was removed in 3.0 release.

Reviewers: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit to confluentinc/kafka that referenced this pull request Nov 22, 2023
`partition.grouper` was removed in 3.0 release.

Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants