KAFKA-15435 Fix counts in MigrationManifest #14342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzyLuke
reviewed
Sep 5, 2023
| @@ -60,7 +61,8 @@ public MigrationManifest build() { | |||
| if (endTimeNanos == 0) { | |||
| endTimeNanos = time.nanoseconds(); | |||
| } | |||
| return new MigrationManifest(total, batches, endTimeNanos - startTimeNanos, counts); | |||
| Map<MetadataRecordType, Integer> orderedCounts = new TreeMap<>(counts); | |||
There was a problem hiding this comment.
qq: why we need a treemap here? Is the sorted order help here?
There was a problem hiding this comment.
Putting into a treemap will order the map according to the keys. The effect of this is that the log message becomes deterministic, which is useful for testing. It's arguably also a bit nicer for end users if the output of the message is consistent.
|
Here are the test failures from Jenkins 
They are all unrelated to migrations, so going ahead and merging this one. |
mumrah
added a commit
that referenced
this pull request
Sep 8, 2023
Reviewers: Liu Zeyu <zeyu.luke@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
mjsax
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Nov 22, 2023
Reviewers: Liu Zeyu <zeyu.luke@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue in MigrationManifest where we weren't computing the record counts properly. A unit test was added to verify the fix.
This patch also changes the counters in MigrationManifest to use an ordered map so we'll get deterministic output.