KAFKA-15449: Verify transactional offset commits (KIP-890 part 1) #14370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
commented
Sep 11, 2023
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java
Outdated
Show resolved
Hide resolved
jolshan
commented
Sep 11, 2023
clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitResponse.java
Outdated
Show resolved
Hide resolved
dajac
reviewed
Sep 25, 2023
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
Outdated
Show resolved
Hide resolved
Comment on lines
455
to
457
| case Errors.INVALID_PRODUCER_ID_MAPPING | ||
| | Errors.INVALID_TXN_STATE => | ||
| Errors.UNKNOWN_MEMBER_ID |
There was a problem hiding this comment.
Could you please explain the rational behind using UNKNOWN_MEMBER_ID here? We should also add a comment about it because this is not obvious.
There was a problem hiding this comment.
Sorry I resolved the PR comment, but I had a discussion with myself here: #14370 (comment)
Similar to the produce request, we wanted to have a non-fatal error here. (I suppose there is an argument for the invalid PID mapping being fatal)
What do you think? There are only 2 abortable errors returned by this request.
} else if (error == Errors.UNKNOWN_MEMBER_ID
|| error == Errors.ILLEGAL_GENERATION) {
abortableError(new CommitFailedException("Transaction offset Commit failed " +
"due to consumer group metadata mismatch: " + error.exception().getMessage()));
There was a problem hiding this comment.
For posterity, we decided to not go with the abortable error and stick with the fatal one since it makes it clearer what happened. We also can't guarantee clients treat unknown member as non-fatal.
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
Outdated
Show resolved
Hide resolved
dajac
approved these changes
Sep 29, 2023
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
Show resolved
Hide resolved
k-wall
pushed a commit
to k-wall/kafka
that referenced
this pull request
Nov 21, 2023
…ache#14370) Previous commits left out TxnOffsetCommits which go through the group coordinator (not directly from the producer). I've wired up the methods to include the transactional id and state partition to do the verification. I've also updated UnifiedLog to verify on client and coordinator requests that are transactional. I've not updated any sequence check logic since the sequence is always 0 on group coordinator initiated writes. Added returned errors to Response files. Both InvalidPidMapping and InvalidTxnState will be returned and be fatal for the transactional OffsetCommit requests. Reviewers: David Jacot <david.jacot@gmail.com>, Artem Livshits <alivshits@confluent.io>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…ache#14370) Previous commits left out TxnOffsetCommits which go through the group coordinator (not directly from the producer). I've wired up the methods to include the transactional id and state partition to do the verification. I've also updated UnifiedLog to verify on client and coordinator requests that are transactional. I've not updated any sequence check logic since the sequence is always 0 on group coordinator initiated writes. Added returned errors to Response files. Both InvalidPidMapping and InvalidTxnState will be returned and be fatal for the transactional OffsetCommit requests. Reviewers: David Jacot <david.jacot@gmail.com>, Artem Livshits <alivshits@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commits left out TxnOffsetCommits which go through the group coordinator (not directly from the producer).
I've wired up the methods to include the transactional id and state partition to do the verification.
I've also updated UnifiedLog to verify on client and coordinator requests that are transactional.
I've not updated any sequence check logic since the sequence is always 0 on group coordinator initiated writes.
Committer Checklist (excluded from commit message)