Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-15498: bump snappy-java version to 1.1.10.5 #14458

Merged
merged 1 commit into from Oct 2, 2023
Merged

KAFKA-15498: bump snappy-java version to 1.1.10.5 #14458

merged 1 commit into from Oct 2, 2023

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Sep 27, 2023 •
edited by divijvaidya

Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. The complete list of commits can be found at xerial/snappy-java@v1.1.10.4...v1.1.10.5

@showuon showuon mentioned this pull request Sep 27, 2023
Merged
3 tasks
jlprat
jlprat approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @showuon

@jlprat jlprat added tests Test fixes (including flaky tests) dependencies Pull requests that update a dependency file labels Sep 27, 2023
@jlprat
Copy link
Contributor

jlprat commented Sep 28, 2023

@showuon can you rebase this one?

@showuon
Copy link
Contributor Author

showuon commented Sep 29, 2023

@jlprat , PR updated. Thanks.

jlprat
jlprat approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @showuon !

@jlprat
Copy link
Contributor

jlprat commented Sep 29, 2023

I was checking the failures and we have a plenty of new flaky tests that seem timing related. It might have been a CI server hiccup. I'll re-run the CI to be sure. Otherwise all the test failures do not seem to be related.

@ijuma
Copy link
Contributor

ijuma commented Sep 29, 2023

I don't think this is a 3.6.0 blocker, so I think we should not merge it to 3.6. Is that fair?

@jlprat
Copy link
Contributor

jlprat commented Sep 29, 2023

@ijuma I agree with you, this is merely a patch update (according to the release notes).
@showuon I see some strange failures regarding:
Failed to load SSL keystore /tmp/truststorexxxxxxxx.jks of type JKS
I don't think any of these are related to the changes.

@showuon
Copy link
Contributor Author

showuon commented Oct 2, 2023

Agree it's not a blocker for v3.6.0. Failed tests are unrelated:

    Build / JDK 21 and Scala 2.13 / kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testDescribeTokenForOtherUserPasses(String).quorum=kraft
    Build / JDK 21 and Scala 2.13 / kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testDescribeTokenForOtherUserFails(String).quorum=kraft
    Build / JDK 21 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
    Build / JDK 11 and Scala 2.13 / kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testCreateTokenForOtherUserFails(String).quorum=kraft
    Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector
    Build / JDK 17 and Scala 2.13 / kafka.server.DescribeClusterRequestTest.testDescribeClusterRequestIncludingClusterAuthorizedOperations(String).quorum=kraft
    Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
    Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()

@showuon showuon merged commit e85b17e into apache:trunk Oct 2, 2023
1 check failed
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Oct 3, 2023
@showuon @rreddy-22
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458)
50ced61 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
jeqo pushed a commit to aiven/kafka that referenced this pull request Oct 4, 2023
@showuon @jeqo
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458)
b04ea42 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
mimaison pushed a commit that referenced this pull request Oct 11, 2023
@showuon @mimaison
KAFKA-15498: upgrade to snappy 1.1.10.5 (#14458)
eade5b8 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
@mimaison
Copy link
Member

FYI, I backported this to 3.6: eade5b8

mimaison pushed a commit that referenced this pull request Oct 12, 2023
@showuon @mimaison
KAFKA-15498: upgrade to snappy 1.1.10.5 (#14458)
b3b457b 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
@mimaison
Copy link
Member

Backported to 3.5 too

k-wall pushed a commit to k-wall/kafka that referenced this pull request Nov 21, 2023
@showuon @k-wall
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458)
e46b843 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
mjsax pushed a commit to confluentinc/kafka that referenced this pull request Nov 22, 2023
@showuon @mjsax
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458)
ca3af6e 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
anurag-harness pushed a commit to anurag-harness/kafka that referenced this pull request Feb 9, 2024
@showuon @anurag-harness
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458)
b6efccf 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>
anurag-harness added a commit to anurag-harness/kafka that referenced this pull request Feb 9, 2024
@anurag-harness @showuon
KAFKA-15498: upgrade to snappy 1.1.10.5 (apache#14458) (#61)
3a82e33 
Release notes - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5

This release contains adds support for Windows ARM and fixes some dependencies associated with Linux ppc64. 

Reviewers: Josep Prat <josep.prat@aiven.io>

Co-authored-by: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlprat jlprat jlprat approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
4 participants
@showuon @jlprat @ijuma @mimaison