KAFKA-14546 - Support Partitioner fallback to default #14531
Conversation
… behavior for unhandled topics.
|
See https://issues.apache.org/jira/browse/KAFKA-14546 for rationale. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
This PR is still valid and desired, has no merge conflicts and does build despite Jenkins protestations. I do not have the ability to add Reviewers. |
| @@ -1368,7 +1368,7 @@ private int partition(ProducerRecord<K, V> record, byte[] serializedKey, byte[] | |||
| if (record.partition() != null) | |||
| return record.partition(); | |||
|
|
|||
| if (partitioner != null) { | |||
| if (partitioner != null && partitioner.partitionsTopic(record.topic())) { | |||
There was a problem hiding this comment.
there's a slight change to the behavior of the current API, could you modify the documentation?
|
@jimbogithub - thanks for the PR, i've got a few questions to clarify:
@jolshan - if you get time maybe you can review this? it seems like you implemented a few partitioner so you are probably the better person to speak about this... thanks! |
| * @param topic The topic name | ||
| */ | ||
| default boolean partitionsTopic(String topic) { | ||
| return true; |
There was a problem hiding this comment.
why is it true by default?
There was a problem hiding this comment.
I think the idea is that this would be implemented differently by different custom partitioners. As default though there is no change from current behavior.
|
I think this change would require a KIP since it modifies the public API. |
Allow custom Partitioners to fallback to default partitioning.