KAFKA-15693: Immediately reassign lost connectors and tasks when scheduled rebalance delay is disabled #14647
+96
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duled rebalance delay is disabled
vamossagar12
approved these changes
Oct 27, 2023
...c/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
Outdated
Show resolved
Hide resolved
yashmayya
approved these changes
Nov 6, 2023
...ct/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
Show resolved
Hide resolved
|
Thanks Yash! Test failures appear unrelated, merging... |
C0urante
added a commit
that referenced
this pull request
Nov 9, 2023
…duled rebalance delay is disabled (#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
C0urante
added a commit
that referenced
this pull request
Nov 9, 2023
…duled rebalance delay is disabled (#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
mjsax
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Nov 22, 2023
…duled rebalance delay is disabled (apache#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
3 tasks
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Jan 2, 2024
…duled rebalance delay is disabled (apache#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
anurag-harness
pushed a commit
to anurag-harness/kafka
that referenced
this pull request
Feb 9, 2024
…duled rebalance delay is disabled (apache#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
anurag-harness
added a commit
to anurag-harness/kafka
that referenced
this pull request
Feb 9, 2024
…duled rebalance delay is disabled (apache#14647) (#224) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com> Co-authored-by: Chris Egerton <chrise@aiven.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…duled rebalance delay is disabled (apache#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…duled rebalance delay is disabled (apache#14647) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
This change is fairly lightweight: when
scheduled.rebalance.max.delay.msis set to0, instead of sending out an intentionally-incomplete assignment with a delay of 0 (which is interpreted by workers as the lack of a scheduled rebalance delay as opposed to a signal to immediately trigger a new rebalance), we immediately reassign all lost connectors and tasks.Committer Checklist (excluded from commit message)