KAFKA-15799 Handle full metadata updates on ZK brokers #14719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
reviewed
Nov 15, 2023
cmccabe
reviewed
Nov 15, 2023
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Nov 15, 2023
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Nov 15, 2023
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Nov 15, 2023
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala
Outdated
Show resolved
Hide resolved
cmccabe
pushed a commit
that referenced
this pull request
Nov 16, 2023
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
|
Can we now close https://issues.apache.org/jira/browse/KAFKA-15799? |
|
@mimaison yup, I closed it just now |
mjsax
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Nov 22, 2023
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Jan 2, 2024
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache. This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605. Reviewers: Colin P. McCabe <cmccabe@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the concept of a "Full" UpdateMetadataRequest, similar to what is used in LeaderAndIsr. A new tagged field is added to UpdateMetadataRequest at version 8 which allows the KRaft controller to indicate if a UMR contains all the metadata or not. Since UMR is implicitly treated as incremental by the ZK broker, we needed a way to detect topic deletions when the KRaft broker sends a metadata snapshot to the ZK broker. By sending a "Full" flag, the broker can now compare existing topic IDs to incoming topic IDs and calculate which topics should be removed from the MetadataCache.
This patch only removes deleted topics from the MetadataCache. Partition/log management was implemented in KAFKA-15605.