KAFKA-16053: Fix leaks of KDC server in tests #15079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divijvaidya
added
tests
|
@dajac @jolshan please review. This is not the root cause of our recent OOM errors but is a contributor to it. (cc: @stanislavkozlovski as a potential backport to 3.7) |
jolshan
approved these changes
Dec 27, 2023
divijvaidya
added a commit
that referenced
this pull request
Dec 28, 2023
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
divijvaidya
added a commit
that referenced
this pull request
Dec 28, 2023
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
|
Nice catch! |
|
backported to 3.6 and 3.7 branch |
gaurav-narula
pushed a commit
to gaurav-narula/kafka
that referenced
this pull request
Jan 24, 2024
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
anurag-harness
pushed a commit
to anurag-harness/kafka
that referenced
this pull request
Feb 9, 2024
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
anurag-harness
added a commit
to anurag-harness/kafka
that referenced
this pull request
Feb 9, 2024
… (#497) This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io> Co-authored-by: Divij Vaidya <diviv@amazon.com>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
This commit closes the KDC server properly in `CustomQuotaCallbackTest` and `AclAuthorizerWithZkSaslTest`. Reviewers: Justine Olshan <jolshan@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are facing OOM while running test suite for Apache Kafka as discussed in https://lists.apache.org/thread/d5js0xpsrsvhgjb10mbzo9cwsy8087x4
Changes
This JIRA fixes ~123MB of heap leak caused by DefaultDirectoryService objects in the heap memory. The
DefaultDirectoryServiceis used byMiniKdc.scala. This change fixes a couple of leaks where the kdc service is not closed at the end of test run.