Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15742: KRaft support in GroupCoordinatorIntegrationTest #15086

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

wernerdv
Copy link
Contributor

updated GroupCoordinatorIntegrationTest to support KRaft

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

updated GroupCoordinatorIntegrationTest to support KRaft
@wernerdv
Copy link
Contributor Author

@wernerdv wernerdv changed the title KAFKA-15742 KRaft support in GroupCoordinatorIntegrationTest KAFKA-15742: KRaft support in GroupCoordinatorIntegrationTest Dec 29, 2023
@divijvaidya divijvaidya added tests Test fixes (including flaky tests) kraft labels Dec 29, 2023
@wernerdv
Copy link
Contributor Author

@divijvaidya If you have a chance, could you take a look at this PR?

@jolshan
Copy link
Contributor

jolshan commented Jan 3, 2024

testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec(String).quorum=kraft PASSED

Looks like it is passing on all builds.

🥳

used 'brokers.head.logManager' for Zk tests too
@wernerdv wernerdv requested a review from jolshan January 3, 2024 14:49
Copy link
Contributor

@jolshan jolshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolshan jolshan merged commit d4aeec3 into apache:trunk Jan 3, 2024
1 check failed
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
…#15086)

updated GroupCoordinatorIntegrationTest.testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec to support KRaft

Reviewers: Justine Olshan <jolshan@confluent.io>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
…#15086)

updated GroupCoordinatorIntegrationTest.testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec to support KRaft

Reviewers: Justine Olshan <jolshan@confluent.io>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…#15086)

updated GroupCoordinatorIntegrationTest.testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec to support KRaft

Reviewers: Justine Olshan <jolshan@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kraft tests Test fixes (including flaky tests)
Projects
None yet
3 participants