KAFKA-15716: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest #15295
Conversation
|
@stejani-cflt |
|
Thanks for the PR. |
|
@mimaison |
|
The build is still failing with Java 8 and Scala 2.12 so we can't merge this PR as is. |
|
Oh thank you! I'll fix it right away |
|
It seems this breaks all the You can run the core tests locally by running |
|
Hi, it looks like there is a typo in the ticket number in the title of this pull request. It says KAFKA-15761, but the change is related to KAFKA-15716 - the last two digits are switched, |
highluck
changed the title
| @BeforeEach | ||
| override def setUp(testInfo: TestInfo): Unit = { | ||
| if (TestInfoUtils.isKRaft(testInfo) && metadataVersion.isLessThan(IBP_3_3_IV0)) { |
There was a problem hiding this comment.
Can you explain why we need this change? metadataVersion is hard coded to MetadataVersion.latestTesting, how can it be less than IBP_3_3_IV0?
There was a problem hiding this comment.
Oh thank you! It seems unnecessary. I'll edit it
|
@mimaison I felt like I needed to think a little more, so I thought it would be a good idea to work on a follow-up PR. |
| @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName) | ||
| @ValueSource(strings = Array("zk", "kraft")) | ||
| def shouldNotAllowDivergentLogs(quorum: String): Unit = { | ||
| if (quorum == "kraft" && metadataVersion.isLessThan(IBP_3_3_IV0)) { |
There was a problem hiding this comment.
Why is this metadata check needed? can you explain it?
| @BeforeEach | ||
| override def setUp(testInfo: TestInfo): Unit = { | ||
| if (TestInfoUtils.isKRaft(testInfo)) { |
There was a problem hiding this comment.
Why are we not running setUp() in KRaft mode?
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Committer Checklist (excluded from commit message)