KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest #15384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
reviewed
Feb 16, 2024
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Feb 16, 2024
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Feb 16, 2024
tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
Outdated
Show resolved
Hide resolved
3 tasks
jolshan
reviewed
Feb 16, 2024
jolshan
reviewed
Feb 16, 2024
clients/src/main/resources/common/message/ListTransactionsRequest.json
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Feb 16, 2024
clients/src/main/resources/common/message/ListTransactionsResponse.json
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Feb 16, 2024
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java
Outdated
Show resolved
Hide resolved
jolshan
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks @yyu1993 I will wait for the tests to run and see if @RamanVerma has any comments.
RamanVerma
reviewed
Feb 19, 2024
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Feb 20, 2024
tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
Outdated
Show resolved
Hide resolved
RamanVerma
reviewed
Feb 22, 2024
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala
Show resolved
Hide resolved
|
I think the unit tests look good. Is it possible to write/edit (in case we have one existing) an integration test that builds a request and validates the response from broker. You will need to feed in some transactions to the broker transactionManager cache as your test data. |
|
Something wrong with the build so I will restart. |
wcarlson5
pushed a commit
to wcarlson5/kafka
that referenced
this pull request
Mar 28, 2024
…equest (apache#15384) Introduces a new filter in ListTransactionsRequest API. This enables caller to filter on transactions that have been running for longer than a certain duration of time. This PR includes the following changes: bumps version for ListTransactionsRequest API to 1. Set the durationFilter to -1L when communicating with an older broker that does not support version 1. bumps version for ListTransactionsResponse to 1 without changing the response structure. adds durationFilter option to kafka-transactions.sh --list Tests: Client side test to build request with correct combination of duration filter and API version: testBuildRequestWithDurationFilter Server side test to filter transactions based on duration: testListTransactionsFiltering Added test case for kafka-transactions.sh change in TransactionsCommandTest Reviewers: Justine Olshan <jolshan@confluent.io>, Raman Verma <rverma@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…equest (apache#15384) Introduces a new filter in ListTransactionsRequest API. This enables caller to filter on transactions that have been running for longer than a certain duration of time. This PR includes the following changes: bumps version for ListTransactionsRequest API to 1. Set the durationFilter to -1L when communicating with an older broker that does not support version 1. bumps version for ListTransactionsResponse to 1 without changing the response structure. adds durationFilter option to kafka-transactions.sh --list Tests: Client side test to build request with correct combination of duration filter and API version: testBuildRequestWithDurationFilter Server side test to filter transactions based on duration: testListTransactionsFiltering Added test case for kafka-transactions.sh change in TransactionsCommandTest Reviewers: Justine Olshan <jolshan@confluent.io>, Raman Verma <rverma@confluent.io>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…equest (apache#15384) Introduces a new filter in ListTransactionsRequest API. This enables caller to filter on transactions that have been running for longer than a certain duration of time. This PR includes the following changes: bumps version for ListTransactionsRequest API to 1. Set the durationFilter to -1L when communicating with an older broker that does not support version 1. bumps version for ListTransactionsResponse to 1 without changing the response structure. adds durationFilter option to kafka-transactions.sh --list Tests: Client side test to build request with correct combination of duration filter and API version: testBuildRequestWithDurationFilter Server side test to filter transactions based on duration: testListTransactionsFiltering Added test case for kafka-transactions.sh change in TransactionsCommandTest Reviewers: Justine Olshan <jolshan@confluent.io>, Raman Verma <rverma@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new filter in ListTransactionsRequest API. This enables caller to filter on transactions that have been running for longer than a certain duration of time.
This PR includes the following changes:
kafka-transactions.sh --listTests:
testBuildRequestWithDurationFiltertestListTransactionsFilteringkafka-transactions.shchange inTransactionsCommandTestCommitter Checklist (excluded from commit message)