-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-16226 Add test for concurrently updatingMetadata and fetching snapshot/cluster #15385
Merged
hachikuji
merged 4 commits into
apache:trunk
from
msn-tldr:kafka_16226_add_concurrent_metadta_test
Feb 26, 2024
Merged
KAFKA-16226 Add test for concurrently updatingMetadata and fetching snapshot/cluster #15385
hachikuji
merged 4 commits into
apache:trunk
from
msn-tldr:kafka_16226_add_concurrent_metadta_test
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2024
All the Jenkins test failures are in different tests, which are already known to have flaky history. |
Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
e4f8997
to
c191950
Compare
hachikuji
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test case, one minor comment.
hachikuji
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wcarlson5
pushed a commit
to wcarlson5/kafka
that referenced
this pull request
Mar 28, 2024
…napshot/cluster (apache#15385) Add test for concurrently updatingMetadata and fetching snapshot/cluster Reviewers: Jason Gustafson <jason@confluent.io> Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…napshot/cluster (apache#15385) Add test for concurrently updatingMetadata and fetching snapshot/cluster Reviewers: Jason Gustafson <jason@confluent.io> Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…napshot/cluster (apache#15385) Add test for concurrently updatingMetadata and fetching snapshot/cluster Reviewers: Jason Gustafson <jason@confluent.io> Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #15323.
Metadata is typically updated concurrently in the background thread, and the MetadataSnapshot/Cluster are fetched & used in another thread(typically application thread). Make sure the concurrent update & read works as expected.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)