Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16226 Add test for concurrently updatingMetadata and fetching snapshot/cluster #15385

Merged

Conversation

msn-tldr
Copy link
Contributor

This is a follow-up to #15323.

Metadata is typically updated concurrently in the background thread, and the MetadataSnapshot/Cluster are fetched & used in another thread(typically application thread). Make sure the concurrent update & read works as expected.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@msn-tldr
Copy link
Contributor Author

All the Jenkins test failures are in different tests, which are already known to have flaky history.

msn-tldr and others added 3 commits February 23, 2024 11:29
Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
@msn-tldr msn-tldr force-pushed the kafka_16226_add_concurrent_metadta_test branch from e4f8997 to c191950 Compare February 23, 2024 11:29
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test case, one minor comment.

Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji merged commit ddfcc33 into apache:trunk Feb 26, 2024
1 check failed
wcarlson5 pushed a commit to wcarlson5/kafka that referenced this pull request Mar 28, 2024
…napshot/cluster (apache#15385)

Add test for concurrently updatingMetadata and fetching snapshot/cluster

Reviewers: Jason Gustafson <jason@confluent.io>

Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…napshot/cluster (apache#15385)

Add test for concurrently updatingMetadata and fetching snapshot/cluster

Reviewers: Jason Gustafson <jason@confluent.io>

Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
…napshot/cluster (apache#15385)

Add test for concurrently updatingMetadata and fetching snapshot/cluster

Reviewers: Jason Gustafson <jason@confluent.io>

Co-authored-by: Zhifeng Chen <ericzhifengchen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants