KAFKA-16261: updateSubscription fails if already empty subscription #15440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndrewJSchofield could you have a look, since you created the ticket? I wasn't quite sure in which sequence of events to observed the problem. The unit test emulates clearing the assignment while leave group is in progress. |
|
@lucasbru Unit tests are failing in |
cadonna
reviewed
Feb 29, 2024
| @@ -764,6 +766,44 @@ public void testLeaveGroupWhenMemberOwnsAssignment() { | |||
| testLeaveGroupReleasesAssignmentAndResetsEpochToSendLeaveGroup(membershipManager); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testLeaveGroupWhenAssignmentEmpty() { | |||
There was a problem hiding this comment.
Is there maybe a more direct way to test the bug?
I had a hard time to understand this unit test.
Nevermind if there is no more direct way.
There was a problem hiding this comment.
Replaced it by a simpler test
| // Complete the callback | ||
| callbackEvent.future().complete(null); | ||
|
|
||
| // Completed the listener |
There was a problem hiding this comment.
This comment does not make too much sense since the leave future is still verified to be not completed.
…y empty subscription The internal SubscriptionState object keeps track of whether the assignment is user-assigned, or auto-assigned. If there are no assigned partitions, the assignment resets to NONE. If you call SubscriptionState.assignFromSubscribed in this state it fails. This change makes sure to check SubscriptionState.hasAutoAssignedPartitions() so that assignFromSubscribed is going to be permitted. Also a minor refactoring to make clearing the subscription a bit easier to follow in MembershipManagerImpl.
lucasbru
force-pushed
the
kip848_empty_subscription
branch
from
651e244
to
f177084
Compare
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…pache#15440) The internal SubscriptionState object keeps track of whether the assignment is user-assigned, or auto-assigned. If there are no assigned partitions, the assignment resets to NONE. If you call SubscriptionState.assignFromSubscribed in this state it fails. This change makes sure to check SubscriptionState.hasAutoAssignedPartitions() so that assignFromSubscribed is going to be permitted. Also, a minor refactoring to make clearing the subscription a bit easier to follow in MembershipManagerImpl. Testing via new unit test. Reviewers: Bruno Cadonna <cadonna@apache.org>, Andrew Schofield <aschofield@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal SubscriptionState object keeps track of whether the assignment is user-assigned, or auto-assigned. If there are no assigned partitions, the assignment resets to NONE. If you call SubscriptionState.assignFromSubscribed in this state it fails.
This change makes sure to check SubscriptionState.hasAutoAssignedPartitions() so that assignFromSubscribed is going to be permitted.
Also, a minor refactoring to make clearing the subscription a bit easier to follow in MembershipManagerImpl.
Testing via new unit test.
Committer Checklist (excluded from commit message)